Look for Words within a Word #38
Open
+29
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Searching words that valid in English-words.txt that contain letters from the word that you search.
Update little and add comment.
nelsonic
reviewed
Feb 28, 2018
look_w.py
Outdated
| import itertools, os | ||
|
|
||
| # locate your folder that contain words.txt | ||
| os.chdir("C:\\Users\\user") |
There was a problem hiding this comment.
this appears to be Microsoft Windows specific ... 💭
Update on replacing variable that use in local instead of global.
Small fix, so valid missing words are collected as well
remove duplicate words
fix little bug
The list of words sorted.
|
@kakkarja @nelsonic I think means it would be better to use a more non-platform specific directory, e.g. the use of C: drive is unique to windows and not on linux, possibly the same with the directory separators, though I am not sure able them. |
Get users default (home) directory
Fix the speed. Faster result even with long words.
Checking total num against the total letters of word.
This reverts commit 1bf0341.
Saw your pull request: dwyl#38 Wanted to show you there was a simpler way to accomplish what you were doing. Also this solution returns words in the original case.
sys imported and unused. os only used to create cwd which is implied with open try/except block that doesn't handle anything json loaded to create a more expensive defaultdict dict created just for membership testing instead of set membership test performed by fetching key value instead of using in
Simplified version of your look_w function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Searching words that valid in English-words.txt that contain letters from the word that you search.
Example:
w = look_w("insane",6)
print(w)
['insane', 'insane', 'inanes', 'inanes', 'insane', 'insane', 'inanes', 'inanes', 'sienna', 'sienna', 'sienna', 'sienna']